Skip to content

Fix malformed dependency adjustment - #288

Closed
Doomguy-BFG9000 wants to merge 2 commits into
djdiskmachine:masterfrom
Doomguy-BFG9000:fix/286-dependency-adjustment
Closed

Doomguy-BFG9000 wants to merge 2 commits into
djdiskmachine:masterfrom
Doomguy-BFG9000:fix/286-dependency-adjustment

Conversation

@Doomguy-BFG9000

Copy link
Copy Markdown

Description

Fix the malformed dependency adjustment reported in #286. The generated dependency rules now append : only to non-empty dependency entries, so Android rebuilds no longer require stale .d files to be removed manually.

The required build number, changelog, and source-build documentation were updated as part of the same fix.

Type of change

How Has This Been Tested?

Ran the exact sed pipeline against a representative generated dependency block containing a target, continued header dependency, comment, and blank line. The output contained only:

src/foo.cpp :
include/foo.h :

Also ran git diff --check successfully.

Test Configuration:

  • Hardware: Windows 11 x64
  • Test steps: Git Bash 5.2.37, GNU sed pipeline regression fixture

Checklist:

  • I have performed a self-review of my code
  • I have commented particularly in hard-to-understand areas (no new complex code)
  • I have updated CHANGELOG
  • I have updated docs/wiki/What-is-LittlePiggyTracker.md reflecting my changes
  • I have version bumped in sources/Application/Model/Project.h
  • My changes generate no new warnings (full platform toolchains are not installed locally; repository CI is expected to verify builds)

@djdiskmachine

Copy link
Copy Markdown
Owner

Thank you for your contribution.
The described issue turned out to be a red herring and can be solved in another way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rules_base contains malformed adjustment

2 participants