Repository navigation
fix(sdl2): use SDL_WINDOW_FULLSCREEN_DESKTOP and reset windowed mode - #285
Open
pinklightultra wants to merge 1 commit into
Open
pinklightultra wants to merge 1 commit into
pinklightultra wants to merge 1 commit into
Conversation
Owner
|
Looks interesting! |
Author
|
It ran on my windows machine. this was just a proposed fix for issues I had for my Xbox rog ally but I wanted to help share it |
pinklightultra
force-pushed
the
fix/sdl2-fullscreen-desktop
branch
from
October 25, 2026 20:23
beee5bc to
a0d615b
Compare
Author
|
Rebased onto latest master (resolving the merge conflict with #284) and verified line-by-line clang-format compliance against the repo's style guidelines. I have also updated the PR description above with the official template, test configuration (Windows 11 & ROG Ally), and verification steps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes fullscreen mode when running the SDL2 driver on modern desktop displays and handhelds (e.g. ASUS ROG Ally, Windows 11 high-DPI/1080p displays):
windowed_ = false;whenFULLSCREENis configured to"YES", ensuringscreenRect_calculates against native display bounds (screenWidth,screenHeight) rather than scaled window dimensions (appWidth * mult_).SDL_WINDOW_FULLSCREEN_DESKTOPinstead ofSDL_WINDOW_FULLSCREENinSDL_CreateWindowto avoid disruptive hardware display mode switches, prevent window scaling artifacts, and scale cleanly to desktop bounds with correct aspect centering.master(resolving conflict with PR Fix text background #284) with strictclang-formatcompliance across all modified lines.Type of change
How Has This Been Tested?
Verified on Windows 11 x64 and handheld PC (ASUS ROG Ally):
FULLSCREEN=YESinconfig.xml.lgpt.exeusing the SDL2 backend.clang-formatcompliance against repository LLVM style.Test Configuration:
FULLSCREEN=YESandFULLSCREEN=NOto verify window sizing and fullscreen scaling.Checklist:
clang-formatcompliant