Repository navigation
Kept the CMDB insertion-failure test hook out of the production library - #99
Conversation
CMDBTestFailInsertion was a writable, exported function pointer in libpromises, consulted on every CMDB load. It now exists only when TEST_UNIT_TEST is defined, and cmdb_test.c includes cmdb.c with that defined, the way split_process_line_test.c does for processes_select.c. In production the check is a constant false and the symbol and its declaration in cmdb.h are gone. The test cases are unchanged. Changelog: None Ticket: none Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The libntech gitlink is a commit of the fork's tendcf-integration branch, which NorthernTechHQ/libntech does not have, so a plain clone could not fetch it. Fork-only: PRs offered upstream keep upstream's URL. Changelog: None Ticket: none Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Automatic reviews are disabled for this repository. Configure in Code Review Settings. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Gate on scratch branch ci-gate/seam-8d8dc94 (PR head 8d8dc94 + the gate workflow): https://github.com/djbclark/core/actions/runs/43645462050 green. Unit 81/81 (cmdb_test 24/24), 06_host_specific_data 18/18, def.json 26 pass + the known soft failure CFE-2956. Symbol check: |
CMDBTestFailInsertionwas a writable, exported function pointer in production libpromises, consulted on every CMDB load (adversary D3 on frdminc/tendcf#41). It now exists only whenTEST_UNIT_TESTis defined:cmdb_test.cincludescmdb.cwith it defined, assplit_process_line_test.calready does forprocesses_select.c. In production the check is a constantfalseand the symbol and itscmdb.hdeclaration are gone. The 24 test cases are unchanged. A second commit points.gitmodulesat https://github.com/djbclark/libntech, since the gitlink is a fork commit; fork-only, upstream PRs keep upstream's URL.Stacked on
cmdb-fail-closed. Gate (scratch branch, same jobs as for PR 98) and the symbol check: see the comment below once it has run.Prior art / docs checked:
rgof the tree for test hooks found one pattern (TEST_UNIT_TESTinprocesses_select.c, set bysplit_process_line_test.c), followed here; no weak symbols or other macros exist. Fork issues and PRs searched for the hook, nothing else.🤖 Generated with Claude Code