Repository navigation
Conversation
|
Automatic reviews are disabled for this repository. Configure in Code Review Settings. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
An entry for a symbolic link now carries its target, mapped out of the changes chroot. Ticket: none Changelog: Title Signed-off-by: Daniel JB Clark <djbclark@gmail.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
djbclark
force-pushed
the
simjson-3-metadata
branch
from
November 14, 2026 16:03
8c5e6ce to
eaa114d
Compare
djbclark
force-pushed
the
simjson-4-symlink
branch
from
November 14, 2026 16:03
adeee11 to
42d2ba4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 4/4 of the
--simulate-jsonstack (fork review vehicle; nothing sent upstream). Supersedes #92 in smaller steps. Base:simjson-3-metadata.Rebuilt 2026-11-14 (comment-only): PR 1 no longer mentions digests (PR 3 adds that comment), PR 1's
.subnotes renames are not in the output yet (PR 2 drops the note). Tip tree still equals #92's799bd0d8c. Adversary verdicts below are for the pre-rebuild heads with identical code (adeee1113); not re-run, no code changed.AI disclosure for the upstream text: "Reviewed with AI help, as in #<PR 1>; the tests are the correctness case."
Adds the symlink
target, mapped out of the changes chroot. The tip tree equals #92's799bd0d8c.Size: +10 non-test C, +1 test.
Linux gate (Ubuntu 24.04 aarch64, root, --enable-debug), head
42d2ba45f: unit All 79 tests passed; simulate_mode_test 16/16;29_simulate_mode/acceptance 8/8 (incl. simulate_json.cf); no warnings in touched files.Negative control: PR 3 tree + this .expected: simulate_json.cf FAIL (no target); no unit test in this PR.
Adversary verdict (head
adeee1113): "APPROVE." Notes: ToNormalRoot() only assert()s its prefix (as ManifestLinkTarget does; unreachable from policy); a readlink() failure dropstargetwithout a log line.Prior art / docs checked: same as #92 (no upstream machine-readable simulate output; cfengine#6294 closed, CFE-4716 rejected).
🤖 Generated with Claude Code