Skip to content

CI only: cfengine/core#6424 review fixes (94b2157b2) - #89

Closed
djbclark wants to merge 3 commits into
masterfrom
ci/6424-review2
Closed

djbclark wants to merge 3 commits into
masterfrom
ci/6424-review2

Conversation

@djbclark

Copy link
Copy Markdown
Owner

CI-only draft for the review-fix commits on top of cfengine#6424 (fork PR #45), run here so the upstream PR branch is not pushed before the reviews finish. Closed and its branch deleted once CI reports.

🤖 Generated with Claude Code

djbclark and others added 3 commits November 3, 2026 06:23
…talls

DiffPkgOperations() compared the versions of two recorded installations
of the same package without checking that both were set, which
PkgVersionIsGreater() asserts. The diff report now keeps the record the
way the manifest report does: a versioned record over an unversioned
one, otherwise the higher version, otherwise the first one recorded.

Ticket: none
Changelog: Title
Signed-off-by: Daniel JB Clark <djbclark@gmail.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Ticket: none
Changelog: None
Signed-off-by: Daniel JB Clark <djbclark@gmail.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The two repeated installation tests now count the lines of the report,
which is what shows the package was reported once.

Ticket: none
Changelog: None
Signed-off-by: Daniel JB Clark <djbclark@gmail.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@djbclark

Copy link
Copy Markdown
Owner Author

CI-only run done: all 9 checks passed on 94b2157, now pushed to the real PR branch (cfengine#6424).

@djbclark djbclark closed this Nov 10, 2026
@djbclark
djbclark deleted the ci/6424-review2 branch November 10, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant