Skip to content

Rejected JSON null primitive values in host_specific.json CMDB data instead of crashing - #63

Open
djbclark wants to merge 46 commits into
masterfrom
fix/cmdb-null-value-crash-r3
Open

djbclark wants to merge 46 commits into
masterfrom
fix/cmdb-null-value-crash-r3

Conversation

@djbclark

@djbclark djbclark commented Nov 1, 2026

Copy link
Copy Markdown
Owner

Rejected JSON null primitive values in host_specific.json CMDB data instead of crashing

JsonPrimitiveToString() returns NULL for a JSON null; in the CMDB
(host_specific.json) loader that NULL was passed to xstrdup() via
EvalContextVariablePut*, so a null variable value segfaulted
cf-promises and cf-agent. A null is now rejected per entry with an error
naming the variable, and the remaining entries in the file are still
installed. Lists that contain a null are deliberately untouched: they
never crashed, and ["a", null] installing the one-element slist
{"a"} (nulls skipped by RlistFromContainer()) is exactly the
upstream/master behaviour this branch keeps; the new acceptance test
asserts it.

Fixes #21

Measured on the exact head ad1766b (one commit on upstream/master
5ac9805): macOS acceptance 00_basics/06_host_specific_data 12/12 Pass
(incl. the new 13-null-values.cf) and 00_basics/def_json 25P/0F/1SF (the
soft failure is the pre-existing augments_classes CFE-2956); Linux gate
(u24 container, --enable-debug): unit check 78/78 rc=0,
simulate_mode_test 5/5, 29_simulate_mode acceptance 7/7 rc=0, and the
branch's own dir 00_basics/06_host_specific_data 12/12 rc=0 in the
container. Negative control: same build with only libpromises/cmdb.c
reverted to upstream/master (tests kept) fails 13-null-values.cf 0/1
(segfault without the fix). cfengine format --check clean on the new
test files.

Adversary review (omp Claude Opus 5.5, read-only): APPROVE, no P0-P2. P3: test file is numbered 13 although upstream has no 12 (cosmetic); the "already rejected" claim holds only for def.json, and the CMDB {"value": null} form does crash and is covered by this fix.

🤖 Generated with Claude Code

victormlg and others added 30 commits October 28, 2026 12:55
Added the reactor tests to jenkins, to be able to run them in jenkins. This
means we can test cf-reactor on all the different platforms.

Signed-off-by: Victor Moene <victor.moene@northern.tech>
Made the logs prettier and added a log file where the xtrace is
printed

Signed-off-by: Victor Moene <victor.moene@northern.tech>
The guest environment cannot contain "-". On hosts containing "-", the
promise fails. The host name is now canonofied.

Signed-off-by: Victor Moene <victor.moene@northern.tech>
X509_get_subject_name() now returns a const name. Build a new
X509_NAME and set it as both subject and issuer instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Tests that print Pass message but have logs errors will fail with `FAIL (Error printed)` message.
Tests which are expected to log errors should use `.error.cf` or `.error.pass.cf` suffix. see: `tests/acceptance/README`

Ticket: CFE-3041
Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
These tests read files created by their own init bundle, but pre-evaluation calls the read functions before the files exist, logging "Could not examine file" errors which now fail regular tests.

Ticket: CFE-3041
Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
Errors printed by the command were reported on lines starting with "error:", so testall mistook them for errors of the test itself.

Ticket: CFE-3041

Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
These tests read files and directories created by their own policy, but pre-evaluation calls the functions before they exist, logging errors which now fail regular tests.

Ticket: CFE-3041
Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
The agent loads def.json from the directory of the input policy file, so tests in 00_basics/ tried to read this directory as their augments file and logged "Could not open JSON file" errors.

Ticket: CFE-3041
Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
The test used the 'immediate' body from plucked.sub.cf before it was
loaded during pre-evaluation, so the promise is now skipped until the
test framework is loaded.

Ticket: CFE-3041
Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
The test referred to a promise module which never existed and did not run its init and cleanup bundles.

Ticket: CFE-3041
Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
The check bundle counted lines in files which do not exist until the test bundle has run, but the agent evaluates the functions of all promises before any bundle runs.

Ticket: CFE-3041
Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
wrong-bundle-type.cf printed the sub-agent output in its DEBUG report, so the sub-agent errors were mistaken for errors of the test, and ifelse.cf used invalid class expressions as false conditions.

Ticket: CFE-3041
Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
These tests intentionally exercise error paths, the reason is documented in the header of each test.

Ticket: CFE-3041
Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
Ticket: CFE-3041
Signed-off-by: Nick Anderson <nick@cmdln.org>
Ticket: CFE-3041
Signed-off-by: Nick Anderson <nick@cmdln.org>
The errorpass branch only checked for logged errors and the Pass
message, so a test marked test_soft_fail or test_skip_unsupported was
reported as FAIL (e.g. process_select_fncalls.error.pass.cf on Windows,
which soft fails due to ENT-10217 and logs no errors there). Errorpass
tests now go through the regular outcome handling and only differ in
requiring at least one logged error on Pass.
Ticket: CFE-3041
Signed-off-by: Nick Anderson <nick@cmdln.org>
Signed-off-by: Dhanraj E <dhanraj@labs.digiscrypt.com>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
…ptions() public

Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
The test promised the current user with policy "present" and expected
the promise to be kept. For an existing user, "present" also means
"not locked". When run as root, cf-reactor can read /etc/shadow, and if
the account's password hash starts with '!' (as root's does on some
systems), it is considered locked and gets unlocked. The promise was
then repaired instead of kept, and the test modified the root account.
As a normal user, /etc/shadow is unreadable, so the account was
considered unlocked and the test passed.

Instead, we modify the policy to always return "kept"

Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi and others added 16 commits October 29, 2026 13:05
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
…be created

Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
…per.c

Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
ENT-14766: Prepared cf-reactor event types for package events
ENT-14766: Moved package module wrapper from cf-agent to libpromises
Ticket: ENT-14765
Changelog: `cf-reactor` can now react to a user being added or removed, with the `user_added` and `user_removed` attributes of `when` bodies
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
CFE-3041: Made testall fail regular acceptance tests which log errors
…Jenkins

Added reactor tests to make check
ENT-14765: cf-reactor: Added user_added and user_removed events
…-path-overflow

fix stack buffer overflow in SaveAsFile backup path construction
A CMDB data file containing a JSON null value crashed cf-promises and
cf-agent with SIGSEGV. Both of these are valid JSON and both crashed:

    {"vars": {"k": null}}
    {"variables": {"k": {"value": null}}}

JsonPrimitiveToString() returns NULL for JSON_PRIMITIVE_TYPE_NULL.
AddCMDBVariable() passed that result straight to
EvalContextVariablePutTagsSetWithComment(), which reaches xstrdup() in
RvalNewRewriter() and dereferences the NULL. The Log() call in between
also passed the NULL to a '%s' conversion, which is undefined behaviour
in its own right.

Reject a null variable value instead, and let the loop continue with the
remaining entries. That is what this file already does for a per-entry
problem: an unusable key in GetCMDBVariableRef(), a missing "value"
field, and every invalid class specification all log an error and skip
just that entry. A single bad key in a generated CMDB file should not
discard the rest of the host's data.

Lists that contain a null are left alone: they never crashed, and
RlistFromContainer() installing ["a", null] as a one-element slist is
pre-existing behaviour this change keeps. Nested nulls reached through a
data container are stored and rendered faithfully.

Changelog: Title
Ticket: none
Signed-off-by: Daniel JB Clark <djbclark@gmail.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T03:09:16.079383Z ad1766b PR opened
🔒 Security Review ✅ Completed 2026-11-01T03:09:14.847191Z ad1766b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@djbclark

Copy link
Copy Markdown
Owner Author

Refreshed against current upstream in #91, with nested-null coverage and fresh Linux positive/negative controls. This branch and its historical evidence are preserved. Details and corrected scope: #21. No upstream submission yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMDB: a JSON null value in host_specific.json segfaults cf-promises and cf-agent

7 participants