You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ManifestPkgOperations() could reuse PkgRecordShouldBeReplaced() #90
PkgRecordShouldBeReplaced() (cf-agent/simulate_mode.c, added for upstream cfengine#6424) is used by DiffPkgOperations(). ManifestPkgOperations() keeps an inline copy of the same rule for the present map (simulate_mode.c ~L1004-1008, on 94b2157):
That condition is logically equivalent to PkgRecordShouldBeReplaced(prev_record, pkg_ver), so it could call the helper. The absent map uses a different rule (it prefers the unversioned record) and stays as is.
Not a bug, just duplication. Offer upstream only if a maintainer raises it on cfengine#6424, or as a separate small PR after cfengine#6424 lands (one upstream PR at a time).
Activity