Skip to content

libntech: SeqStringReadFile() never closes its fd #34

Open

Description

@djbclark

Found while looking for code to reuse in #27. libntech/libutils/string_sequence.c SeqStringReadFile() opens the file and never closes it. This is true in the submodule and on libntech origin/master. No core caller uses it yet.

To do: a 1-line libntech fix. After that, the --simulate-json record readers could switch to it and drop about 25 more lines.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions