Skip to content

fix(report): use matrix_pool_scope for alert-only rows and update taxonomy plan - #60

Open
djbclark wants to merge 1 commit into
mainfrom
fix/alert-row-scope-and-taxonomy-doc
Open

djbclark wants to merge 1 commit into
mainfrom
fix/alert-row-scope-and-taxonomy-doc

Conversation

@djbclark

Copy link
Copy Markdown
Owner

Summary

  • Route _row_from_alert in src/aiuse/report.py through matrix_pool_scope(pool_id, [scope_window], provider=alert.provider) so alert-only matrix rows use the exact same SCOPE logic as account-derived and deferred rows (notably codex alert rows now carry SCOPE=codex instead of —), and remove the unused _POOL_SCOPE_LABELS alias.
  • Update docs/taxonomy-migration-plan.md so Section 1 distinguishes pre-Phase-2 state from shipped Phase 2 (Schema 1.6 additive fields + POOL / SCOPE display alignment, including the codex / openai / chatgpt aliases) while Phases 3–4 remain pending.
  • Add regression tests in tests/test_report.py (test_alert_only_row_scope_matches_matrix_pool_scope) and update test_default_report_is_clock_matrix for codex alert-row SCOPE.

Coordination

Coordinated with b0b47ad8 (Lead (Pi successor)):

  • Left D1 (docs/json-contract.md) on hold until fix/pi-pool-freshness merges to avoid conflicts.
  • Left D3 (djbclark-ade canary_pools / canary_pool()) and D4 (R3-L1 OverflowError, already fixed at b6efa71) to b0b47ad8.

Verification

  • ruff format / ruff check / mypy / prettier --check: all passed.
  • Local pytest -q (full suite): 2010 passed in 26.94s.
  • Smoke tests (AIUSE_SKIP_HOMEBREW_FORMULA=1): watch --once, aiuse, aiuse --json, and aiuse --available --json succeeded.
  • GitHub Actions test.yml (workflow_dispatch on 8b869b6): https://github.com/djbclark/aiuse/actions/runs/44122853520 (success, 2m8s).

Adversary review

Verdict: APPROVE — no findings (head SHA 8b869b6 / 8b869b625c2559715360b6d0409bc5c38aa8c943, branch fix/alert-row-scope-and-taxonomy-doc). No security, secrets, I/O, or injection vectors introduced; _row_from_alert, matrix_pool_scope, alias normalization, and docs/taxonomy-migration-plan.md verified.

@greptile-apps

greptile-apps Bot commented Nov 17, 2026

Copy link
Copy Markdown

Automatic reviews are disabled for this repository. Configure in Code Review Settings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T16:17:31.466798Z 8b869b6 PR opened
🔒 Security Review ✅ Completed 2026-11-17T16:18:58.271490Z 8b869b6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant