img.onload fix issues with img.width = 0#3
Open
danton721 wants to merge 1 commit into
Open
Conversation
Fixed the issue of: Failed to execute 'drawImage' on 'CanvasRenderingContext2D': The image argument is a canvas element with a width or height of 0. dizhar#1. Had to return promise to comply with asynchronous onload. Could've been made synchronous by following this example: https://www.gamedev.net/forums/topic/650999-synchronous-loading-of-images-in-html5/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the issue of: Failed to execute 'drawImage' on 'CanvasRenderingContext2D': The image argument is a canvas element with a width or height of 0. #1.
Had to return promise to comply with asynchronous onload. Could've been made synchronous by following this example: https://www.gamedev.net/forums/topic/650999-synchronous-loading-of-images-in-html5/
Please test, as I've just tested inside my application as a function and worked fine for me, copied in the Github editor and done this PR.