fix(dm-worker): restore build when follow re-check ack has no operation id - #83
Merged
diwenne merged 1 commit intoOct 5, 2026
Conversation
…on id diwenne#68 passed a nullable operationId into sendPostbackOnce, which only accepts a string, so next build failed type checking. Send the ack directly when there is no id; the Redis NX lock above already dedupes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@felipemazetti is attempting to deploy a commit to the diwenne's projects Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
npm run build,npm run typecheckand the Docker image fail onmainsince #68 (257e38d):sendFollowRecheckAckreceivesoperationId: string | nulland passes${operationId}:ackornullintosendPostbackOnce, whoseoperationIdisstring. (Also reported in #82.)Fix
With an id, keep the durable claim through
sendPostbackOnce(unchanged). Without one, send the ack directly: thefollow_recheck_ackRedisSET NXright above already limits it to one ack per re-check cycle.Verification
docker buildwith the repo Dockerfile completes again (next buildtype check passes), and the image runs on a self-hosted instance with web and worker healthy (/api/healthok).