Skip to content

🎨 Palette: Add keyboard shortcut hints to interactive elements - #80

Open
divineforge wants to merge 1 commit into
mainfrom
ux/add-aria-keyshortcuts-1606133412227780671
Open

🎨 Palette: Add keyboard shortcut hints to interactive elements#80
divineforge wants to merge 1 commit into
mainfrom
ux/add-aria-keyshortcuts-1606133412227780671

Conversation

@divineforge

Copy link
Copy Markdown
Collaborator

💡 What: Added aria-keyshortcuts to the ThemeToggle and PathCard components, and updated their titles to visually indicate the shortcut.
🎯 Why: To make existing keyboard shortcuts discoverable for sighted users via native tooltips and announce them to screen reader users via ARIA.
📸 Before/After: Visual titles added (e.g. (Press T)).
♿ Accessibility: Better communication of custom keyboard bindings to assistive tech.


PR created automatically by Jules for task 1606133412227780671 started by @divineforge

Co-authored-by: divineforge <1146195+divineforge@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying gzen-invest with  Cloudflare Pages  Cloudflare Pages

Latest commit: b90339a
Status:🚫  Build failed.

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying gzen-ki with  Cloudflare Pages  Cloudflare Pages

Latest commit: b90339a
Status: ✅  Deploy successful!
Preview URL: https://8c4c90bb.gzen-ki.pages.dev
Branch Preview URL: https://ux-add-aria-keyshortcuts-160.gzen-ki.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying gzen-learn with  Cloudflare Pages  Cloudflare Pages

Latest commit: b90339a
Status:🚫  Build failed.

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying gzen with  Cloudflare Pages  Cloudflare Pages

Latest commit: b90339a
Status: ✅  Deploy successful!
Preview URL: https://e1afa0c5.gzen.pages.dev
Branch Preview URL: https://ux-add-aria-keyshortcuts-160.gzen.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant