🎨 Palette: Expose custom keyboard shortcuts - #78
Open
divineforge wants to merge 4 commits into
Open
Conversation
Added `aria-keyshortcuts` attributes to the theme toggle and path cards to expose their custom keybindings to assistive technologies. Also appended the shortcuts to the `title` attributes so they are discoverable via hover for sighted users. Included a journal entry in `.Jules/palette.md` for this accessibility pattern. Co-authored-by: divineforge <1146195+divineforge@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Deploying gzen with
|
| Latest commit: |
a628693
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d53864eb.gzen.pages.dev |
| Branch Preview URL: | https://palette-keyboard-shortcuts-5.gzen.pages.dev |
Deploying gzen-invest with
|
| Latest commit: |
a628693
|
| Status: | 🚫 Build failed. |
Deploying gzen-ki with
|
| Latest commit: |
a628693
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://53f99db1.gzen-ki.pages.dev |
| Branch Preview URL: | https://palette-keyboard-shortcuts-5.gzen-ki.pages.dev |
Deploying gzen-learn with
|
| Latest commit: |
a628693
|
| Status: | 🚫 Build failed. |
Added `aria-keyshortcuts` attributes to the theme toggle and path cards to expose their custom keybindings to assistive technologies. Also appended the shortcuts to the `title` attributes so they are discoverable via hover for sighted users. Included a journal entry in `.Jules/palette.md` for this accessibility pattern. Fixed an issue where older Hugo configurations using `languageCode` caused CI pipeline failures by updating `hugo.toml` configurations to use `locale`. Co-authored-by: divineforge <1146195+divineforge@users.noreply.github.com>
Added `aria-keyshortcuts` attributes to the theme toggle and path cards to expose their custom keybindings to assistive technologies. Also appended the shortcuts to the `title` attributes so they are discoverable via hover for sighted users. Included a journal entry in `.Jules/palette.md` for this accessibility pattern. Co-authored-by: divineforge <1146195+divineforge@users.noreply.github.com>
Added `aria-keyshortcuts` attributes to the theme toggle and path cards to expose their custom keybindings to assistive technologies. Also appended the shortcuts to the `title` attributes so they are discoverable via hover for sighted users. Included a journal entry in `.Jules/palette.md` for this accessibility pattern. Co-authored-by: divineforge <1146195+divineforge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What: Added
aria-keyshortcutsand updatedtitleattributes on the ThemeToggle and PathCard components.🎯 Why: These elements have custom JavaScript keyboard shortcuts (
Tfor theme toggle,K/I/L/Ofor path cards) that were previously undiscoverable by sighted users and hidden from screen readers. This micro-UX enhancement makes them accessible to all.♿ Accessibility: The
aria-keyshortcutsattribute exposes the bindings to assistive technologies, making the custom shortcuts fully accessible and compliant with ARIA standards for custom keybindings.📸 Before/After: The visual change adds the shortcut to the native browser tooltip on hover. (See verification artifacts)
PR created automatically by Jules for task 5934063332654614888 started by @divineforge