🎨 Palette: Keyboard Shortcuts Accessibility & Visual Hints - #77
🎨 Palette: Keyboard Shortcuts Accessibility & Visual Hints#77divineforge wants to merge 3 commits into
Conversation
Added `aria-keyshortcuts` and visual hints in the `title` attributes for custom keyboard shortcuts in `ThemeToggle.astro` and `PathCard.astro` to improve discoverability and accessibility for both sighted and screen reader users. Added entry to `.Jules/palette.md` logging the learning. Co-authored-by: divineforge <1146195+divineforge@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Deploying gzen-invest with
|
| Latest commit: |
874620c
|
| Status: | 🚫 Build failed. |
Deploying gzen-ki with
|
| Latest commit: |
874620c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a42a306a.gzen-ki.pages.dev |
| Branch Preview URL: | https://palette-keyboard-shortcuts-1.gzen-ki.pages.dev |
Deploying gzen-learn with
|
| Latest commit: |
874620c
|
| Status: | 🚫 Build failed. |
Deploying gzen with
|
| Latest commit: |
874620c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://46e25291.gzen.pages.dev |
| Branch Preview URL: | https://palette-keyboard-shortcuts-1.gzen.pages.dev |
The Cloudflare Pages CI check failed for `gzen-invest` and `gzen-learn` because they are Hugo sites, but Cloudflare was trying to run `npm run build` by default. Adding `wrangler.toml` files to `apps/gzen-invest`, `apps/gzen-learn`, and `apps/gzen-ki` explicitly configures the build command to `hugo --gc --minify` and sets the `HUGO_VERSION`. Co-authored-by: divineforge <1146195+divineforge@users.noreply.github.com>
Cloudflare Pages defaults to running `npm run build` if no specific build command is configured via the dashboard or `wrangler.toml` with the V2 build system in some cases, or it specifically looks for a `package.json`. Added `package.json` with a build script and `.nvmrc` to `apps/gzen-invest`, `apps/gzen-learn`, `apps/gzen-ki`, and `apps/gzen-om` to ensure the CI uses the correct `hugo --gc --minify` command during the build step. This also maintains the `wrangler.toml` explicit configuration. Co-authored-by: divineforge <1146195+divineforge@users.noreply.github.com>
1 participant
💡 What: Added
aria-keyshortcutsto the ThemeToggle and PathCard components and appended the shortcut key as a visual hint in theirtitleattributes.🎯 Why: The portal includes interactive elements with custom keyboard shortcuts (like
Tfor theme toggle, orK/I/L/Ofor path cards), but these shortcuts were completely invisible. Adding these attributes makes them accessible to screen readers and discoverable by sighted users via hover tooltips.♿ Accessibility: Provides
aria-keyshortcutsfor screen readers and updatestitletooltips to visually communicate the shortcuts. Logged the learning to.Jules/palette.md.PR created automatically by Jules for task 15372104859268511183 started by @divineforge