🎨 Palette: Language Switcher Accessibility Improvement - #57
Conversation
- Add `lang` and `hreflang` attributes to the language switcher links. - Add `data-lang` attribute to the language switcher links. - Add `id="lang-toggle"` to the `<nav>` container for JS compatibility. - Added a journal entry for the Palette persona documenting these findings. Co-authored-by: divineforge <1146195+divineforge@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Deploying gzen with
|
| Latest commit: |
10548d2
|
| Status: | 🚫 Build failed. |
1 participant
This PR improves the accessibility and UX of the language toggle links by providing
langandhreflangattributes, which ensures screen readers apply correct pronunciation profiles for the target languages. Furthermore, it adds the necessaryidanddata-langattributes so the existinglanguage-toggle.jsscript can persist user preferences properly. A.Jules/palette.mdjournal entry was added per the persona instructions.PR created automatically by Jules for task 1648675381801085918 started by @divineforge