Fix for python3 issues#36
Conversation
|
@thoas looks like all of the python 3 tests fail because our dependencies aren't python 3 compatible. :( |
|
@mattrobenolt yep, it seems pycassa is not compatible at all with python3 : even the current master doesn't pass at all. Do you have a recommendation for this case? I think we need to disable pycassa tests for py3. |
|
I'm not sure off the top of my head. I think that's reasonable though if that's the only incompatibility. tbh though, I'd like to rip out pycassa support since that's silly in nydus. :) Not sure why it was a thing in the first place. |
|
Also, pycassa is deprecated in favor of https://github.com/datastax/python-driver, so I'd be open to ripping that out if we get full python 3 compat without it. |
* Rename assertEquals to assertEqual * Rename assertNotEquals to assertNotEqual * Add httplib and next in compat * Fix map use cases which does not return a list anymore in py3
|
@mattrobenolt I have disabled pycassa tests in Python 3 context. I need your brain on a nasty choice in Python 3, mine is melting. I lost the What do you suggest for these case scenario? |
|
@mattrobenolt 🎉 🎉 tests are passing on py2/py3 Give me your feedback when you will have the time :) |
|
@mattrobenolt any time on your side to review this PR? Thanks :) |
|
This mostly seems ok to me. /cc @dcramer opinions? |
|
idc you guys are in charge :) |
|
|
|
I'm going to review this and compare with my progress that I made on my py3 branch from a while ago that I didn't finish. master...py3 for reference. |
|
We are in charge 😱 😱 |
|
@mattrobenolt any feedback on this? Thank you :) |
crc32Available if you want more information.