Prefix based router support#12
Conversation
tschellenbach
commented
May 15, 2012
There was a problem hiding this comment.
This path needs updated, right?
|
I wonder if this would be a good time to add some kind of router options to the configuration. That could help a lot if we wanted to address #11 by not requiring the dict config approach |
There was a problem hiding this comment.
Perhaps I missed something, but is there a default host in your example docstring?
|
Nice work. Can you also add a couple more tests to test the code paths in |
|
Awesome, thanks for the very thorough feedback. Good to see such traction behind the project. We've forked Nydus for 2 reasons.
Both features are unit tested and included in the pull request. |
|
Why wasn't this merged? |