Optimize value_to_abstract/2#6
Open
AndrewDryga wants to merge 1 commit into
Open
Conversation
Most of `value_to_abstract/2` return can be precompiled so that less `:erl_syntax` work is necessary to build an Erlang abstract term. This also allowed to remove private `:erl_syntax` import from this module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of
value_to_abstract/2return can be precompiled so that less:erl_syntaxwork is necessary to build an Erlang abstract term.This also allowed to remove private
:erl_syntaximport from this module.Results on my laptop:
where
fastglobalaltis changed module which I've submitted in the PR.Performance improvement is almost not noticeable, so It's up to you to decide does this PR deserves to be merged it or not :).