Skip to content

Release 4.36.0: collection row markers for Visual Editor Enhancements 1.7 - #9

Merged
dirnbauer merged 9 commits into
mainfrom
feature/4.35-markers
Nov 8, 2026
Merged

dirnbauer merged 9 commits into
mainfrom
feature/4.35-markers

Conversation

@dirnbauer

Copy link
Copy Markdown
Owner

Collection row markers (f:mark.item) in every Content Block template, so Visual Editor Enhancements 1.7 can show row controls on the page.

  • Codemod Build/Scripts/codemod-collection-markers.php (--check, idempotent): 189 loops in 156 elements, 185 marked (149 HTML roots, 37 d: component roots, 2 merged attributes), 4 listed exceptions (chart JSON/value loops, gallery featured view).
  • Six molecules accept attributes (CheckedListItem, TableRow, TableCell, FeatureItem, TabsTrigger, TabsContent), output byte-identical.
  • VEE constraint ^1.6 || dev-main; no-output f:mark.item fallback when VEE is not loaded (RowMarkerFallback).
  • Gates: unit 1160, functional SQLite 145, PHPStan 8, cgl, codemod --check 0; anonymous render of all 263 element previews byte-identical (forms after masking EXT:form tokens); edit-mode sweep: 709 visible children, 728 markers, every collection name valid.

🤖 Generated with Claude Code

dirnbauer and others added 9 commits November 8, 2026 09:45
…m fallback

The Content Block templates will mark collection rows with f:mark.item,
which ships with Visual Editor Enhancements 1.6.0. The old constraint
(^0.8 || ^1.0) allowed releases without it. Where the extension is not
loaded at all (classic mode, setups without it), ext_localconf.php
registers a stand-in on the f namespace that renders '' / [] - what the
real ViewHelper renders outside edit mode - so no template fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Build/Scripts/codemod-collection-markers.php marks the root of every
<f:for> over a Collection field (config.yaml) with f:mark.item: HTML roots
get an inline marker before '>', d: components get attributes= (merged
with f:merge where attributes already exist). The tokenizer, loop
analyser, rewriter and the exception list live in
Classes/Templates/CollectionMarker so the lint test shares them.
--check fails on unmarked, unlisted or unresolved loops and stray
markers; --dry-run prints the changed lines; a second run changes nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CheckedListItem, TableRow, TableCell, FeatureItem, TabsTrigger and
TabsContent are collection row roots; they now accept attributes like
Card and spread them onto their root tag. The spread sits on an existing
line, so with no attributes the markup is unchanged. The generator emits
the same for the two generated tabs primitives.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Output of php Build/Scripts/codemod-collection-markers.php: 189
collection loops in 156 elements, 185 marked (188 roots: 149 HTML, 37
components, 2 merged attributes), 4 listed exceptions (chart,
chart-contribution and chart-donut JSON/computation loops, gallery
featured view).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The new argument and its comment on lines of their own rendered two
extra newlines (a before/after render of all 263 element previews showed
18 differences, blank lines only). The comment now bridges the previous
argument's line, so the components emit exactly what they did; the
generator writes the tabs primitives the same way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
{f:render(...)} starts like {key: ...}; merging it with f:merge would
have produced a broken expression. It is now reported as unmergeable.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- ContentBlockCollectionMarkerTest: every loop is marked or a listed
  exception (189 loops, 185 marked, 4 exceptions, 175 collections), no
  marker outside loop roots, row root components accept attributes,
  marker names the looped column and variable.
- CollectionMarkerCodemodTest: the codemod rules on small templates,
  idempotence, merges, exceptions, stray/wrong markers, parser errors.
- ComponentStructureTest::testRowRootMoleculesDeclareAttributes.
- SeedVisualEditorInlinePageFunctionalTest renders each element of the
  inline showcase through the preview page type: in edit mode (real
  backend session) one marked row per visible child of every collection,
  nested cells and gallery thumbnails included; for visitors no data-ve-*.
- RowMarkerFallbackFunctionalTest: without Visual Editor Enhancements the
  stand-in renders, in edit mode too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
capture renders every preview URL of desiderio:library:urls (optionally
in edit mode), compare checks two captures byte for byte, masking only
EXT:form's per-request honeypot and signed state. Used to prove the row
markers left the published markup of all 263 previews unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Version 4.36.0 in composer.json and ext_emconf.php (4.35.0 was released
from main meanwhile); the CHANGELOG entry stays unreleased.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dirnbauer
dirnbauer merged commit 6008121 into main Nov 8, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant