Repository navigation
Release 4.36.0: collection row markers for Visual Editor Enhancements 1.7 - #9
Merged
Merged
Conversation
…m fallback The Content Block templates will mark collection rows with f:mark.item, which ships with Visual Editor Enhancements 1.6.0. The old constraint (^0.8 || ^1.0) allowed releases without it. Where the extension is not loaded at all (classic mode, setups without it), ext_localconf.php registers a stand-in on the f namespace that renders '' / [] - what the real ViewHelper renders outside edit mode - so no template fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Build/Scripts/codemod-collection-markers.php marks the root of every <f:for> over a Collection field (config.yaml) with f:mark.item: HTML roots get an inline marker before '>', d: components get attributes= (merged with f:merge where attributes already exist). The tokenizer, loop analyser, rewriter and the exception list live in Classes/Templates/CollectionMarker so the lint test shares them. --check fails on unmarked, unlisted or unresolved loops and stray markers; --dry-run prints the changed lines; a second run changes nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CheckedListItem, TableRow, TableCell, FeatureItem, TabsTrigger and TabsContent are collection row roots; they now accept attributes like Card and spread them onto their root tag. The spread sits on an existing line, so with no attributes the markup is unchanged. The generator emits the same for the two generated tabs primitives. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Output of php Build/Scripts/codemod-collection-markers.php: 189 collection loops in 156 elements, 185 marked (188 roots: 149 HTML, 37 components, 2 merged attributes), 4 listed exceptions (chart, chart-contribution and chart-donut JSON/computation loops, gallery featured view). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The new argument and its comment on lines of their own rendered two extra newlines (a before/after render of all 263 element previews showed 18 differences, blank lines only). The comment now bridges the previous argument's line, so the components emit exactly what they did; the generator writes the tabs primitives the same way. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
{f:render(...)} starts like {key: ...}; merging it with f:merge would
have produced a broken expression. It is now reported as unmergeable.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- ContentBlockCollectionMarkerTest: every loop is marked or a listed exception (189 loops, 185 marked, 4 exceptions, 175 collections), no marker outside loop roots, row root components accept attributes, marker names the looped column and variable. - CollectionMarkerCodemodTest: the codemod rules on small templates, idempotence, merges, exceptions, stray/wrong markers, parser errors. - ComponentStructureTest::testRowRootMoleculesDeclareAttributes. - SeedVisualEditorInlinePageFunctionalTest renders each element of the inline showcase through the preview page type: in edit mode (real backend session) one marked row per visible child of every collection, nested cells and gallery thumbnails included; for visitors no data-ve-*. - RowMarkerFallbackFunctionalTest: without Visual Editor Enhancements the stand-in renders, in edit mode too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
capture renders every preview URL of desiderio:library:urls (optionally in edit mode), compare checks two captures byte for byte, masking only EXT:form's per-request honeypot and signed state. Used to prove the row markers left the published markup of all 263 previews unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Version 4.36.0 in composer.json and ext_emconf.php (4.35.0 was released from main meanwhile); the CHANGELOG entry stays unreleased. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection row markers (
f:mark.item) in every Content Block template, so Visual Editor Enhancements 1.7 can show row controls on the page.Build/Scripts/codemod-collection-markers.php(--check, idempotent): 189 loops in 156 elements, 185 marked (149 HTML roots, 37d:component roots, 2 merged attributes), 4 listed exceptions (chart JSON/value loops, gallery featured view).attributes(CheckedListItem, TableRow, TableCell, FeatureItem, TabsTrigger, TabsContent), output byte-identical.^1.6 || dev-main; no-outputf:mark.itemfallback when VEE is not loaded (RowMarkerFallback).🤖 Generated with Claude Code