Conversation
- pawan-core: remove unused imports, fix mut variables - pawan-cli: fix clamp, sort_by_key, checked_div, needless borrows - rename ExportFormat::from_str to parse to avoid std trait confusion - fix unused variables in tests with .. rest patterns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves all remaining clippy
-D warningserrors across the pawan workspace.Changes:
pawan-core/src/agent/mod.rs— Remove unused imports (get_api_key_with_secure_fallback,summarize_args,PawanError), addValuetomod testsimportpawan-core/src/agent/irc.rs— Restoremutonmainwheretry_receive()is calledpawan-cli/src/tui/irc_panel.rs— Remove unusedmutonworkervariablespawan-cli/src/tui/model_catalog.rs— Replacesort_bywithsort_by_key+Reverse, remove redundantuse serde_json;pawan-cli/src/tui/queue_panel.rs— Replace.min(3).max(1)with.clamp(1, 3)pawan-cli/src/tui/render.rs— Remove needless&ininsert_str(&format!(...)), remove redundantuse insta;pawan-cli/src/tui/slash_handlers.rs— Use.enumerate()on iterator,sort_by_keyfor case-insensitive sort,checked_divfor safe divisionpawan-cli/src/tui/types.rs— RenameExportFormat::from_strtoparseto avoid confusion withstd::str::FromStr::from_strpawan-cli/tests/tui_types_tests.rs— Fix unused variables in match arms, updatefrom_str→parsereferencesVerification: All 1643 tests pass,
cargo clippy --all-features --all-targets -- -D warningsexits clean.