Skip to content

fix: resolve all clippy -D warnings across workspace#25

Merged
bkataru merged 1 commit into
mainfrom
holy
May 29, 2026
Merged

fix: resolve all clippy -D warnings across workspace#25
bkataru merged 1 commit into
mainfrom
holy

Conversation

@bkataru
Copy link
Copy Markdown
Member

@bkataru bkataru commented May 29, 2026

Resolves all remaining clippy -D warnings errors across the pawan workspace.

Changes:

  • pawan-core/src/agent/mod.rs — Remove unused imports (get_api_key_with_secure_fallback, summarize_args, PawanError), add Value to mod tests import
  • pawan-core/src/agent/irc.rs — Restore mut on main where try_receive() is called
  • pawan-cli/src/tui/irc_panel.rs — Remove unused mut on worker variables
  • pawan-cli/src/tui/model_catalog.rs — Replace sort_by with sort_by_key + Reverse, remove redundant use serde_json;
  • pawan-cli/src/tui/queue_panel.rs — Replace .min(3).max(1) with .clamp(1, 3)
  • pawan-cli/src/tui/render.rs — Remove needless & in insert_str(&format!(...)), remove redundant use insta;
  • pawan-cli/src/tui/slash_handlers.rs — Use .enumerate() on iterator, sort_by_key for case-insensitive sort, checked_div for safe division
  • pawan-cli/src/tui/types.rs — Rename ExportFormat::from_str to parse to avoid confusion with std::str::FromStr::from_str
  • pawan-cli/tests/tui_types_tests.rs — Fix unused variables in match arms, update from_strparse references

Verification: All 1643 tests pass, cargo clippy --all-features --all-targets -- -D warnings exits clean.

- pawan-core: remove unused imports, fix mut variables
- pawan-cli: fix clamp, sort_by_key, checked_div, needless borrows
- rename ExportFormat::from_str to parse to avoid std trait confusion
- fix unused variables in tests with .. rest patterns
@bkataru bkataru merged commit 7066518 into main May 29, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant