Change NodeLabel into a synonym for str - #159
Draft
davidweichiang wants to merge 3 commits into
Draft
davidweichiang wants to merge 3 commits into
davidweichiang wants to merge 3 commits into
Conversation
… different type.) - Lots of possibly unrelated type annotations added, to help mypy track down all the uses of NodeLabel.
davidweichiang
changed the title
davidweichiang
marked this pull request as draft
August 15, 2022 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #140 I outlined why I thought EdgeLabel should be restructured. This PR does the easier flip side, which is to restructure NodeLabel. Unlike EdgeLabel, NodeLabel doesn't have any extra information other than a string, so this PR just makes NodeLabel into a str.