Reject incompatible MinHashLSH merges#4
Closed
dipeshbabu wants to merge 1 commit into
Closed
Conversation
dipeshbabu
marked this pull request as ready for review
July 19, 2026 03:50
Owner
Author
|
Superseded by upstream pull request ekzhu#328. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Require matching key serialization, band hash callables, and byte-key requirements in addition to the existing band layout checks before merging indexes.
Why
Copying rows from an index with a different band hash function makes those entries unreachable. Mixing pickled and raw key representations also corrupts membership and query behavior.
Impact
Incompatible merges now fail before mutating the destination. Compatible indexes with different thresholds, weights, or storage backends can still merge when their effective representation matches.
Root cause
The equivalence check covered only num_perm, band count, and band size.
Checks