Enforce MinHash construction compatibility#2
Closed
dipeshbabu wants to merge 1 commit into
Closed
Conversation
dipeshbabu
marked this pull request as ready for review
July 19, 2026 03:50
Owner
Author
|
Superseded by upstream pull request ekzhu#326. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fingerprint the actual permutation matrix and hash callable, then enforce those fingerprints in MinHash operations and all LSH variants.
Why
Sketches with the same seed, length, and scheme can still be incompatible when callers provide different permutations or hash functions. Comparing or indexing them together silently produces invalid similarity results.
Impact
Jaccard, merge, union, LSH, async LSH, LSH Forest, and LSH Bloom now fail clearly when known construction metadata differs. WeightedMinHash remains exempt, and old indexes carrying only scheme metadata remain readable.
Root cause
Compatibility checks treated the seed as a complete identity for permutation generation and did not track the input hash function.
Checks