Fix b-bit MinHash estimator correction#1
Closed
dipeshbabu wants to merge 1 commit into
Closed
Conversation
dipeshbabu
marked this pull request as ready for review
July 19, 2026 03:50
Owner
Author
|
Superseded by upstream pull request ekzhu#325. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Correct the b-bit MinHash A(r, b) denominator to use the required 2^b exponent and add a focused regression test.
Why
The previous 2*b exponent produced a biased correction whenever b was greater than two and r was nonzero.
Impact
Jaccard estimates using a nonzero universe ratio now follow the published estimator. The r=0 behavior is unchanged.
Root cause
The exponentiation term was transcribed as multiplication.
Checks