Fixed HorizontalListView child element layout changes not being redrawn on the fly#40
Open
MartinHarkins wants to merge 1 commit intodinocore1:masterfrom
Open
Fixed HorizontalListView child element layout changes not being redrawn on the fly#40MartinHarkins wants to merge 1 commit intodinocore1:masterfrom
MartinHarkins wants to merge 1 commit intodinocore1:masterfrom
Conversation
…ayout change. Changes to the size of view elements within one of the child views were not being reflected on screen (until scrolling the element out and back in). The issue was the HorizontalListView onLayout call wasn't re-measuring the child view in onLayout. This meant that if updating a TextView with a longer text, the text was being truncated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to the size of view elements within one of the child views were not being reflected on screen (until scrolling the element out and then back in).
The issue was that the HorizontalListView.onLayout call wasn't re-measuring the child view in onLayout before laying it out.
This meant that the new text of a TextView was being truncated on screen as the view was not resizing itself.