Repository navigation
[build] Build liburing statically; order Folly after it - #74
Merged
jackblack369 merged 1 commit intoSep 18, 2026
Merged
Conversation
chuandew
marked this pull request as ready for review
September 18, 2026 08:24
jackblack369
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ENABLE_SHARED=0Why
Folly auto-detected Eureka's shared
liburing.soand exported it throughFolly::folly_deps. DingoFS consumers then acquired a runtime dependency onliburing.so.2, while the runtime image only carries the statically linked dependency set.The explicit dependency also prevents Folly configuration from racing liburing installation or falling back to the system library.
Validation
liburing.aandliburing-ffi.a, with no liburing shared objectFolly::folly_depsexports/tmp/dingo-eureka-build/lib/liburing.aecf98eb4086ca6c2473942e2581aee3205deff5b)DT_NEEDEDentry forliburing.soand no unresolved runtime librariesdingo-mds-client --helpreaches application startup without a loader error