Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adversarial-review follow-up for Code Mode namespace casing and Labby-owned MCP App visibility.
Namespace resolution
upstreamsand namespacedtoolsfilters against configured upstream names.ToolScopeauthorization semantics.MCP App visibility findings addressed
mcp_appswitchboard andallbehavior.artifactstext service remains usable while its UI is disabled.CI/adversarial follow-up
McpAppsConfig::defaultimplementation with a derived default to satisfy Clippy.fsandskillsreduced-feature slices by gating every Skill Library visibility read behind the gateway feature or an explicit false fallback.artifacts, so the bulk-disable test now verifies UI/resource hiding without asserting a raw descriptor that the route contract suppresses.Verification
cargo fmt --allandgit diff --checkpass.cargo check -p labby-gateway -p labby --libpasses.fs, andskillsCI lanes pass after the follow-up fixes.