fix(skills): accept interoperable allowed-tools forms - #687
Merged
Merged
Conversation
jmagar
enabled auto-merge (squash)
September 19, 2026 02:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowed-toolsfrontmatter in addition to the normative Agent Skills string formtool_hintswithout splitting spaces inside parenthesized tool patternsWhy
Live Labby was excluding valid Skills emitted by real Agent Skills tooling as
invalid_frontmatter. Dendrite also uses comma-delimited strings thatskills-refaccepts, while Labby previously tokenized them into bogus names such asRead,. SEP-2640 already requiresallowed-toolsto remain a hint rather than an implicit permission grant.Verification
cargo fmt --manifest-path crates/labby-runtime/Cargo.toml -- --checkcargo clippy -p labby-runtime --all-features --lib --locked -- -D warningscargo test -p labby-runtime --all-features --locked skills::→ 90 passedcargo test -p labby-runtime --all-features --locked --test skills_contract_conformance→ 8 passedcargo test -p labby-runtime --all-features --locked --test sep_2640_uri_conformance→ 11 passedcargo test -p labby-gateway --all-features --locked skills→ 84 passedcargo clippy -p labby-runtime --all-features --all-targets --locked -- -D warningsis independently red on pre-existingunused_async_trait_implwarnings inagent_runtime.rstest fixtures, outside this diff.