Repository navigation
fix(release): test joined output in the Windows packaged smoke - #599
Merged
Merged
Conversation
PowerShell captures native output as an array of lines, and -notmatch on an array returns the non-matching lines. The Skills check was therefore truthy for any multi-line help output and failed even when the expected text was present, which kept v1.15.1 from qualifying. Join the output with Out-String before matching, for both the Code Mode and the Skills check, and include the captured help text in the failure message.
jmagar
added a commit
that referenced
this pull request
Sep 11, 2026
🤖 I have created a release *beep* *boop* --- ## [1.16.0](v1.15.1...v1.16.0) (2026-09-11) ### Added * **depot:** add full administration control plane ([#567](#567)) ([c83333c](c83333c)) ### Fixed * **auth:** support Codex native loopback OAuth redirects ([#573](#573)) ([163ef53](163ef53)) * **cli:** report rejected gateway config as invalid_param instead of panicking ([#580](#580)) ([f56822e](f56822e)) * **codemode:** bound one-shot CLI catalog cold connects and persist partial results ([#579](#579)) ([f66a3b7](f66a3b7)) * **codemode:** discover read-ready upstream resource URIs ([#592](#592)) ([5c6af13](5c6af13)) * **codemode:** negative-cache failed one-shot catalog upstream probes ([#584](#584)) ([d29bb30](d29bb30)) * **deploy:** keep the team-labby example route loadable on current main ([#585](#585)) ([00b375f](00b375f)) * **file-stash:** own the upload reservation in the spawned finalize task ([#590](#590)) ([2fb1f86](2fb1f86)) * **gateway:** classify stdio lifecycle from the MCP error, not child stderr ([#586](#586)) ([60cf776](60cf776)) * **gateway:** do not respawn stdio upstreams that exit before the handshake ([#582](#582)) ([9f7fb59](9f7fb59)) * preserve Skills over MCP across client and server transports ([#571](#571)) ([b6ad223](b6ad223)) * **release:** test joined output in the Windows packaged smoke ([#599](#599)) ([3d34d2b](3d34d2b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v1.15.1 release never qualified: its Build (x86_64-pc-windows-msvc) job failed at the packaged smoke with Packaged binary does not expose the required Skills surface, even though v1.15.1 compiled the
skillsfeature and carried the expected help text.The check was wrong, not the binary. PowerShell captures native command output as an array of lines, and
-notmatchapplied to an array returns the non-matching lines rather than a boolean. For multi-lineskills --helpoutput that result is always non-empty, so theifis always true and the step throws.This joins the captured output with
Out-Stringbefore matching, for both the Code Mode and Skills checks, and adds the captured help text to the failure message. The guard incrates/labby/tests/ci_changed_paths.rsstill sees three occurrences of bothskills --helpand the help text.This unblocks the pending 1.16.0 release (#569), which would otherwise fail the same way.
Test plan
release.ymlparses as YAML🤖 Generated with Claude Code