Skip to content

fix: native MCP Skills transport and capability-aware artifact controls - #571

Merged
jmagar merged 5 commits into
mainfrom
codex/skills-mcp-e2e
Sep 8, 2026
Merged

jmagar merged 5 commits into
mainfrom
codex/skills-mcp-e2e

Conversation

@jmagar

@jmagar jmagar commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve native Skills responses in the production capped HTTP client.
  • Pin both workspace and auth rmcp dependencies to the published SDK fixes in fix(rmcp): preserve raw responses through OAuth and header caching rust-sdk#2 (f94e8fa).
  • Add required CI coverage for real-process HTTP/stdio server and federation, OAuth wrapper compatibility, manifest reads/digests, and fail-closed exposure policy.
  • Gate Artifact Control Plane on registered runtime services: disabled or unavailable services show guidance and retry rather than controls that call absent endpoints. No user configuration changed.

Verification

  • Native Skills end-to-end: 6/6 passed using the published pin with --locked, no local override.
  • Gateway suite: 1213/1213 passed with four workers against the SDK fixes; five skipped. A one-second process-output test timed out at high concurrency and passed at four workers.
  • UI unit tests: 617 passed; installer tests: 2 passed; focused Artifact control tests: 6 passed.
  • UI static export, TypeScript, targeted ESLint, actionlint and diff checks passed.
  • Playwright rendered desktop 1365x900 and mobile 390x844: unavailable guidance, retry, no authority requests, no console/page errors. Controlled auth/service fixtures, not production acceptance.
  • Independent SDK and UI review completed; SDK review follow-up strengthened worker-level tests.

Boundaries

No deployment, service restart, configuration toggle, ingestion, or PR merge. The SDK dependency PR remains open for human review.

@github-actions github-actions Bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Sep 8, 2026
@jmagar

jmagar commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator Author

Review completed across correctness, errors/types, tests, comments/docs/config, and simplification. No remaining actionable findings. Both rmcp pins and lockfile entries resolve to published SDK f94e8fa with no patch override. Latest native Skills E2E: 6/6 passed with --locked. Earlier full gateway suite against the same production SDK fixes: 1213/1213 with four workers (five skipped), not claimed as a final-pin rerun. UI: 617 unit + 2 installer tests, six focused cases, static export/TypeScript, targeted ESLint, actionlint, and diff checks passed. Playwright desktop/mobile validated unavailable-state guidance and retry with zero authority endpoint requests and zero console/page errors under controlled fixtures. Narrow-screen action clipping was found and fixed. Live config, service, installation, and ingestion were not changed.

@jmagar

jmagar commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator Author

Follow-up 7c23f44 adds a controlled authorization-server E2E: production OAuth manager metadata discovery, code exchange, PKCE verifier assertion, proactive refresh, and native Skills list/get/resource reads from a real Labby server without a static client bearer. Consent is simulated; browser/external-provider acceptance and reactive 401 refresh are not claimed. Independent delta review found no actionable findings. Final local Skills suite 7/7 passed (30538607), strict focused Clippy passed. Prior d464eeb conformance and focused MCP CI passed; new head requires fresh CI. Mac service enablement was separately authorized and performed; no production TOOTIE deployment or merge.

@jmagar

jmagar commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator Author

Additional final-pin verification: full labby-gateway suite passed 1213/1213 (5 skipped) on7c23f44e8 using published SDKf94e8fa, --all-features --locked and four test threads. Nextest run03dc1a66-a620-4cbb-978f-9cd4f60d9035,130s. This supersedes the earlier local-SDK-only full gateway evidence. Final-head CI34268847229 remains in progress; no CI completion claim yet.

@jmagar

jmagar commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator Author

User-approved follow-up95bf4c795 addresses the sole failing prior CI test: concurrent installation identity publication on Windows returned sharing violation32 rather than AlreadyExists. Recovery accepts only collision errors and reads the winner through existing secure validation; unrelated publication/durability errors remain errors. Original concurrency test retained; held-reader winner,invalid winner,and error-preservation tests added. Review found broad fallback could mask directory-sync errors; narrowed and re-reviewed clean. Local bootstrap group18/18passed f47e36e3;strict libraryClippy passed. Native Windows validation is pending new CI; no retry/suppression or merge.

@jmagar
jmagar merged commit b6ad223 into main Sep 8, 2026
51 checks passed
@jmagar
jmagar deleted the codex/skills-mcp-e2e branch September 8, 2026 20:16
jmagar added a commit that referenced this pull request Sep 11, 2026
🤖 I have created a release *beep* *boop*
---


## [1.16.0](v1.15.1...v1.16.0) (2026-09-11)


### Added

* **depot:** add full administration control plane ([#567](#567)) ([c83333c](c83333c))


### Fixed

* **auth:** support Codex native loopback OAuth redirects ([#573](#573)) ([163ef53](163ef53))
* **cli:** report rejected gateway config as invalid_param instead of panicking ([#580](#580)) ([f56822e](f56822e))
* **codemode:** bound one-shot CLI catalog cold connects and persist partial results ([#579](#579)) ([f66a3b7](f66a3b7))
* **codemode:** discover read-ready upstream resource URIs ([#592](#592)) ([5c6af13](5c6af13))
* **codemode:** negative-cache failed one-shot catalog upstream probes ([#584](#584)) ([d29bb30](d29bb30))
* **deploy:** keep the team-labby example route loadable on current main ([#585](#585)) ([00b375f](00b375f))
* **file-stash:** own the upload reservation in the spawned finalize task ([#590](#590)) ([2fb1f86](2fb1f86))
* **gateway:** classify stdio lifecycle from the MCP error, not child stderr ([#586](#586)) ([60cf776](60cf776))
* **gateway:** do not respawn stdio upstreams that exit before the handshake ([#582](#582)) ([9f7fb59](9f7fb59))
* preserve Skills over MCP across client and server transports ([#571](#571)) ([b6ad223](b6ad223))
* **release:** test joined output in the Windows packaged smoke ([#599](#599)) ([3d34d2b](3d34d2b))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant