chore: scrub internal network identifiers - #11
Merged
Merged
Conversation
Collaborator
Author
|
Verified all reviewer findings from the identifier-scrub review are resolved on this branch (already addressed in an earlier commit on the branch):
No functional changes. |
added 2 commits
September 13, 2026 14:28
Replace private homelab identifiers that leaked into this public repo with generic, non-identifying placeholders: - Private LAN addresses -> 192.0.2.0/24 (RFC 5737 documentation range), keeping the last octet stable so distinct hosts stay distinguishable. - Overlay/mesh addresses -> 198.51.100.0/24, with a stable per-address mapping so repeated references still point at the same placeholder. - The private mesh domain suffix -> example.ts.net, and the bare mesh network name -> a generic placeholder. - Personal host aliases -> role-based placeholder names (NAS, dev host, edge host, backup host, Windows host, laptop host, etc.), renamed consistently everywhere they appear (docs, plugin manifests, script defaults, data structures) so nothing is left inconsistent. - Personal subdomains of a private domain -> a generic internal placeholder domain; the one already-public registry subdomain was left untouched since it must keep resolving. Sanity check: ran this repo's own plugins/scripts/check-all (JSON schema validation + full Python test suite + marketplace/doc consistency checks) both before and after the edits; identical test counts, identical pre-existing warnings, exit 0 both times.
Rename leftover tootie_df/tootie_parity locals to nashost_df/nashost_parity to match the renamed snapshots["nashost"] key, use the *.example.internal placeholder consistently for the public domain field instead of coining *.nashost.tv, and fix the ASCII diagram alignment in screenshots/README.md after the winhost-wsl placeholder rename.
jmagar
force-pushed
the
chore/scrub-internal-identifiers-20260805
branch
from
September 13, 2026 18:33
fbfa4e1 to
ac6a068
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracked examples and documentation now use neutral, reserved identifiers instead of internal network names, addresses, domains, and host aliases. The scrub keeps configuration examples useful while preventing repository content from encoding a specific private environment.
Why This Exists
Internal infrastructure identifiers had accumulated across plugin metadata, skills, documentation, and the homelab report generator. Those values were unnecessary for users and made otherwise reusable guidance specific to one environment.
Resolution
Reviewer Considerations
The primary review concern is completeness and consistency: every replacement should remain syntactically valid for its surrounding configuration while avoiding real internal identifiers. No runtime behavior is intended to change.
Behavior Changes
None. Documentation, defaults, examples, and generated report labels now use neutral placeholders.
Verification
mainwithout conflictsplugins/scripts/check-allpassedgit diff --check origin/main...HEADpassedRisk
Low. The changes are identifier substitutions across documentation, metadata, scripts, and generated content; repository validation covers schema and marketplace consistency.