Conversation
…2e coverage, patch high-severity audit vulns
- ci.yml: keep policy/web/android as inline jobs (not reusable workflow_call
jobs, which always report as "<caller> / <called-job>") so their check
names literally match the branch ruleset's required contexts: "Workflow
and dependency policy", "OSV dependency scan", "Web, registry, and
standalone", "Android app and library variants".
- Restore the Android PR-time job (androidCheck, androidManagedDeviceCheck,
ops/smoke-android-composite.sh) that the fleet-contract migration dropped.
- web job: run `pnpm run build` before `pnpm run audit:standalone` (the
latter requires .next/standalone to exist) and restore performance:check
+ test:e2e coverage that the migration to fast-pnpm.yml lost.
- plugin/.claude-plugin/plugin.json: restore the version key, bumped to
0.1.1, instead of leaving it deleted.
- pnpm-workspace.yaml/pnpm-lock.yaml: widen/add overrides so undici,
fast-uri, ip-address, and brace-expansion resolve past their advisories,
clearing the `pnpm audit --audit-level high` gate (4 high -> 0 high).
Verified locally: actionlint clean, ops/check-action-pins.sh clean,
pnpm run build -> pnpm run audit:standalone passes in that order, pnpm
run {lint,test:unit,registry:check,registry:validate,registry:graph,
gallery:check,catalog:check,tokens:generate,refs:check,performance:check,
audit:composition} all pass with no generated-artifact drift, tsc --noEmit
clean, pnpm audit --audit-level high reports 0 high/critical.
The required "OSV dependency scan" status check (osv-scanner-action, which scans by lockfile regardless of pnpm's own audit-level filter) was still failing after the audit-level-high fix: the existing hono and postcss overrides pinned to versions that were current when originally added but have since been superseded by newer advisories. - hono: 4.12.27 -> 4.12.34 (GHSA-8j4g-w8fx-2239) - postcss: 8.5.19 -> 8.5.23 (GHSA-fxqj-rqcc-2cmp) Verified with the exact image/version CI uses: `docker run ghcr.io/google/osv-scanner:v2.3.8 --lockfile=pnpm-lock.yaml` -> "No issues found". `pnpm audit --audit-level high` now also reports zero known vulnerabilities of any severity.
Collaborator
Author
|
Addressed the review findings on this PR:
Verified locally: |
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns this repo's CI workflows and docs with current fleet-wide conventions.