Small updates #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With cancellation logic in the constructor a reuse of the socket is not possible. By moving it into the ConnectAsync() method the client can connect and disconnect without always creating a new instance of the WebSocketTextClient class.
Task.Start() should never be called in the first place. It introduces problems and should be avioded. See: https://stackoverflow.com/a/29693430/1922663
The internal token source was never initialized, this has been fixed.
- Receive task is now started as fire and forget in the constructor - Receive task now only handles messages, when the socket has an open connection - Exposed uncerlying socke object as a public read only property - Exposed a public "Connected" read only property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves on cancellation and fixes some critical bugs involving the async code, see commit messages for more details.