Skip to content

Cleanup: stale enabled models, refresh_items scheduling, README auto-config docs#581

Merged
dale-wahl merged 2 commits intoollama_managementfrom
copilot/sub-pr-576
Mar 10, 2026
Merged

Cleanup: stale enabled models, refresh_items scheduling, README auto-config docs#581
dale-wahl merged 2 commits intoollama_managementfrom
copilot/sub-pr-576

Conversation

Copy link
Contributor

Copilot AI commented Mar 10, 2026

Three follow-up fixes from PR review on the Ollama/LLM management feature.

Changes

  • ollama_manager.py — reconcile llm.enabled_models on refresh
    After updating llm.available_models, refresh_models() now diffs against llm.enabled_models and removes any model keys no longer present in the available list. Prevents stale enabled entries accumulating silently across delete/re-pull cycles.

  • refresh_items.py — disable no-op scheduling
    ensure_job is commented out so ItemUpdater no longer enqueues itself every 60 seconds to do nothing. Worker class is preserved for future use with an explanatory comment.

  • docker/README.md — clarify auto- vs. manual LLM config
    Splits "Configuring 4CAT to use Ollama" into two subsections:

    • Automatic configuration — notes that docker_setup.py auto-sets LLM fields on first startup when using the sidecar override; users can skip manual steps.
    • Manual configuration — retains the settings table for verification or external server setups.
      "Using an external Ollama server" now cross-references the manual config steps explicitly.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…ADME docs

Co-authored-by: dale-wahl <32108944+dale-wahl@users.noreply.github.com>
Copilot AI changed the title [WIP] Add Ollama setup via Docker and manage LLM models UI Cleanup: stale enabled models, refresh_items scheduling, README auto-config docs Mar 10, 2026
Copy link
Member

@dale-wahl dale-wahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dale-wahl dale-wahl marked this pull request as ready for review March 10, 2026 11:56
@dale-wahl dale-wahl merged commit eb4b49a into ollama_management Mar 10, 2026
@dale-wahl dale-wahl deleted the copilot/sub-pr-576 branch March 10, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants