Open
Conversation
…dataset results folder it's working on pixplot datasets and the new cartagrapher datasets by using there manifests and data subfolder!
idea being we can have a configurable cartographer and run default "image wall" settings
Still do not know why but nothing renders; even the atlas images!
…Processor.display_in_ui() Allow using `display_in_ui` to hide processors from UI but allow them to be queued either via API or presets. This avoids issue of is_compatible_with() having to be used to hide processors with sometimes ill effects.
…is_compatible_with
cannot just check plot since preview also checks child datasets of zips for plots
Member
Author
Member
Author
finally figured this out!
Member
Member
|
I would also suggest to rename the processor to something more specific. "Create Image visualisation" is a bit general; something like "Display images on Web page" is already a bit more concrete. Relatedly, it is a bit unclear to me what can I do with the outputted zip file. Can the description be updated so users are told what they can do with it? And maybe add a readme file in the zip results? As I understand it, the page opened by the "View" button is what's most interesting here right? Can't the zip file contain this page as well? Otherwise good work!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This is merge-able!
Notes:
@app.route('/result/<path:query_file>')now can also load archived files.This may not be the best design and we might perhaps not archive the images since they have this new use. Recommend reviewing this part.Updated to open files and generate response on the fly.To-do:
I have done some basic editing to the PixPlot template, but it could benefit from more work.More editing done for 4CAT specific plots!Add metadata to the Image descriptionsMove the image description panel to one of the sides; it works where it is with the image filename only, but is not great/intuitive with further descriptionsedit add presets for tiktok and telegram image downloaders