Open
Conversation
Abhishek-lodha
suggested changes
Jun 7, 2018
|
|
||
| from mi_data_structure import * | ||
| from loop.models import * | ||
| import pandas as pd |
Contributor
There was a problem hiding this comment.
Please organise the imports appropriately
| gaddidar_data_obj = Gaddidar.objects.filter(mandi__id__in=mandi_list) | ||
|
|
||
| # Read CSV file and filter for requested Aggreagator | ||
| filepath = os.path.join(fileDir, "/home/trionfo/Documents/dg/loop/utils/Transport Cost & Capacity Data - Sheet1.csv") |
Contributor
There was a problem hiding this comment.
remove hard coded file path & print statement
| def query_for_rates(crop_list, mandi_list, date_range=3): | ||
| # today_date = datetime(2018, 03, 21) | ||
| today_date = datetime.now() | ||
| today_date = datetime(2018, 05, 22) |
| url(r'^get_partners_list/', get_partners_list), | ||
| url(r'^admin/logout/?$', 'django.contrib.auth.views.logout', {'next_page': '/loop/admin/'}), | ||
| url(r'^admin/', include(loop_admin.urls)), | ||
| url(r'^get_agg_mi_data', get_aggregator_mi_related_data), |
Contributor
There was a problem hiding this comment.
append slash after the urls
| return agg_list_requested | ||
|
|
||
|
|
||
| # def getJSONObj(**kwargs): |
Contributor
There was a problem hiding this comment.
remove commented code
|
|
||
|
|
||
| def is_authenticated(request): | ||
|
|
Contributor
There was a problem hiding this comment.
add function doc string to explain the working of function
| cropobj = Crop.objects.values_list('id', flat=True) | ||
| cropobj = map(int, cropobj) | ||
| # Prepare data | ||
| crop_list = tuple(cropobj) |
Contributor
There was a problem hiding this comment.
if only 1 crop is requested, will this tuple method work?
| latest_price_date = pd.Timestamp('2015-01-01') | ||
| cropmandidata = CropMandiData(crop_id=i[0], mandi_id= i[1]) | ||
| for index, row in r.iterrows(): | ||
| crop, mandi, date, Av_Rate, STD, PriceMax, PriceMin = row['Crop'], row['Market_Real'], row['Date'], row['Av_Ratemean'], row['STDmean'], row['Pricemax'], row['Pricemin'] |
Contributor
There was a problem hiding this comment.
Are we sure that avg_price and std are always returned from the function?
Contributor
Author
There was a problem hiding this comment.
You doubt that? :<, BTW yes.
| mandi_res = [] | ||
| for mandiobj in mandi_data_obj: | ||
| mandiobjdetail = MandiDetail(mandi_id=mandiobj['id'], mandi_name=mandiobj[mandi_name_label], mandi_category='Chhoti Mandi',\ | ||
| mandi_distance='590') |
Contributor
There was a problem hiding this comment.
why are category and distance hardcoded?
Contributor
Author
There was a problem hiding this comment.
For Initially, testing.
| self.cost = kwargs['transport_cost'] | ||
| self.capacity = kwargs['transport_capacity'] | ||
|
|
||
| def getTransportDetail(self): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Market Information in Loop App.
Release Steps :
Test
Prod