coco_api version 1.0.0#1004

Open

vermastuti wants to merge 36 commits intomasterfrom

Contributor

vermastuti commented May 8, 2020 •

edited

Loading

Steps to apply changes:

Install libraries from requirements.txt
(mainly djangorestframework==3.6.4
djangorestframework-csv==2.1.0)
(Only in case tokens are not generated) Run python manage.py migrate command to implement TokenAuthentication
Implement changes in base_settings.py
Run python manage.py runserver

Changes summary:

New files have been added and changes are made in the following apps:
-- activities
-- videos
-- geographies
-- people
-- programs
New api to get a match for provided comma separated phone numbers in people module has been added
A new property F_count has been added to people serializer to ease calculation in Redash for data visualization
A new folder coco_api has been created to keep utils, permissions and constants files
Logging has been added for views and the folder is: coco_api/log/logfile.log
Pagination has been added for all views
Permission named IsDGRestricted has been added to control access to views on the basis of django.contrib.auth.models.Group as mapped by PERMISSIONS_MAP in constants.py

tionfo and others added 21 commits

March 19, 2020 16:44


          Added Django Rest Framework

37ed1e4


          Added DRF in requirement.txt

3a33446

and mysql related lib


          geo-&-people-serializers

e82194c


          coco-api-version1.0.0

2c53b4d


          count-param-edited

78ea845


          req-txt-updated

04ecd3c


          base_settings_updated

bc688f6


          programs-api-added-and-csrf-auth-bug-exists

6ed47eb


          resolved-csrf-issue

883dc77


          standard-urls-and-names

798c1b0


          phone-no-farmers-filter

b1950c9


          dashboard-F_count

bded534


          match-people-phone-numbers-api

848893a


          people-post-requests-merged

8e83408


          limit-queryset-function

db84ff0


          coco_api_utils

52d242b


          logging-changes

fec3889


          logging-with-utils

313009a


          pagination-applied

57d5382


          view-permission-IsDGRestricted-added

b61949a


          permissions

b6846f3

sagardg reviewed

View reviewed changes

dg/urls.py Outdated

sagardg reviewed

View reviewed changes

dg/urls.py Outdated

sagardg reviewed

View reviewed changes

dg/urls.py Outdated

sagardg reviewed

View reviewed changes

dg/urls.py Outdated

sagardg reviewed

View reviewed changes

geographies/serializers.py

sagardg reviewed

View reviewed changes

geographies/serializers.py Outdated

sagardg reviewed

View reviewed changes

geographies/serializers.py Outdated

sagardg reviewed

View reviewed changes

geographies/serializers.py Outdated

sagardg reviewed

View reviewed changes

geographies/serializers.py Outdated

sagardg reviewed

View reviewed changes

dg/base_settings.py Outdated

sagardg reviewed

View reviewed changes

dg/base_settings.py

sagardg reviewed

View reviewed changes

activities/urls.py Outdated

sagardg reviewed

View reviewed changes

activities/views.py Outdated

sagardg reviewed

View reviewed changes

activities/views.py Outdated

sagardg reviewed

View reviewed changes

activities/views.py Outdated

sagardg reviewed

View reviewed changes

dg/urls.py Outdated

sagardg reviewed

View reviewed changes

videos/urls.py Outdated

sagardg reviewed

View reviewed changes

activities/urls.py Outdated

sagardg reviewed

View reviewed changes

people/views.py

sagardg reviewed

View reviewed changes

people/views.py

                           queryset = Person.objects.all().order_by('id')
+                      if phoneNumberExists in ["true","t","yes","y"]:
+                          queryset = queryset.filter(phone_no__isnull=False).exclude(phone_no__in=[''])

Contributor

sagardg Jun 10, 2020

logic incorrect as it would provide numbers like 9, 0, 1 etc. Add a more generalised logic for numbers.

sagardg reviewed

View reviewed changes

people/views.py Outdated

sagardg reviewed

View reviewed changes

people/views.py Outdated

Contributor

sagardg commented Jun 10, 2020

try to add try except blocks where ever you think your code could break and try adding testcases.

vermastuti added 2 commits

June 11, 2020 01:48


          api-app-changes

f454919


          admin-changes

c6e6687

sujit22993 self-assigned this

vermastuti and others added 13 commits

June 11, 2020 18:58


          comments-linegaps

f0cc1e2


          code-review-changes

2c9f352


          function-comments

4f4f03b


          add-line-EOF

ddf463b


          namespaces-added-to-urls

85057fa


          change queries to lower case

df3f536


          mysql-errors-fixed

96eddb3


          people-FarmersCsvAPIView-limitquery

f91bc72


          change variable name

ea40765


          resolve loading issue & change google charts version

77c63d0


          change key name from YEAR, MONTH to year, month

a432733


          add file

cb7fedc


          Merge remote-tracking branch 'origin/analytics_fix' into coco_api_stuti

e629bf2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet