feat(external-call): Add Canton protocol support for external calls#441
Draft
trusch wants to merge 7 commits intodigital-asset:mainfrom
Draft
feat(external-call): Add Canton protocol support for external calls#441trusch wants to merge 7 commits intodigital-asset:mainfrom
trusch wants to merge 7 commits intodigital-asset:mainfrom
Conversation
|
🎉 Thank you for your contribution! It appears you have not yet signed the Agreement DA Contributor License Agreement (CLA), which is required for your changes to be incorporated into an Open Source Software (OSS) project. Please kindly read the and reply on a new comment with the following text to agree: I have hereby read the Digital Asset CLA and agree to its terms You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
a7066d8 to
925741f
Compare
925741f to
ac964a2
Compare
ac964a2 to
a57f965
Compare
…eedback - Proto: config_hash/input_hex/output_hex (string) -> config/input/output (bytes) - Proto: Remove call_index field (repeated is already ordered) - Scala: ExternalCallResult fields now use data.Bytes instead of String - Test generators: Updated to generate binary data instead of hex strings
…r review - Add EXTERNAL_CALL to LF test parser (ExprParser.scala) - Add EXTERNAL_CALL to parser spec (ParsersSpec.scala) - Add externalCall entry to Builtin_2.dev_.lf
- Add ResultNeedExternalCall to Engine results - Implement SBExternalCall builtin in Speedy - Add NeedExternalCall question type - Update PartialTransaction to store external call results - Update CostModel for external calls
…alls - Encode/decode ExternalCallResult in TransactionCoder - Update serialization version handling
- Extend ActionDescription with external call results - Update participant_transaction.proto - Update ViewParticipantData - Update NodeHashBuilder for external call hashing
a57f965 to
ccdfa1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Canton-specific protocol support for external calls, including ActionDescription extensions, view participant data, and transaction hashing.
Requires #440
Changes
Proto Definition (
participant_transaction.proto)ActionDescription (
ActionDescription.scala)Extended
ExerciseActionDescriptionto include external call results:ViewParticipantData (
ViewParticipantData.scala)NodeHashBuilder (
NodeHashBuilder.scala)Added external call results to exercise node hash:
View Decomposition
External call results are aggregated at the view level:
Hashing
External call results are included in the transaction hash to ensure:
Testing
ExampleTransactionFactory.scala- Factory for test transactionsWellFormedTransactionTest.scala- Well-formedness checksNodeHashV1Test.scala- Hash computation tests