Skip to content

Proposal: Deprecate preset.geometry and add preset.docType #310

Description

@gmaclennan

The preset schema defines a geometry field, and array of point | line | area | vertex | relation. This defines what type of geometries the preset should match to, and we use it to determine what categories (presets) to show to a user when creating an observation or a track.

This proposal is to deprecate the preset.geometry field and add a new preset.docType field, an array of CoMapeo schema names that this preset applies to e.g. observation | track.

The geometry field was inherited from our use of iD Editor, and the values correspond to the document types in the OSM database. We have used point as a synonym for "observation" and recently line as a synonym for "track". However, looking forward to future map editing with CoMapeo, we will also be adding point, line and area doc types to core, with a "point" on a map being different to an "observation" (an "observation" is a point-in-time subjective observation of a point, line or area on the map). We may wish for different presets to be visible when creating points that are visible when creating an observation. With the current geometry field we will be unable to do that. We could always add additional permitted items to the geometry field, e.g. it could also allow observation and track, however that does not allow a smooth transition for existing projects which have been using geometry: point. Adding a new field allows us backwards-compatibility: we can use docType: observation if the docType field exists, but it it doesn't then fall back to geometry: point.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions