SDK-181: Update requests to 2.34.2 - #249
Merged
Merged
Conversation
Ran poetry update requests, bumping it from 2.32.4 to 2.34.2, the latest release allowed by the existing ^2.32.4 constraint. Only poetry.lock changed; pyproject.toml is untouched.
cjfuller-dev
changed the title
cjfuller-dev
marked this pull request as ready for review
July 22, 2026 10:34
cjfuller-dev
changed the title
cariad
approved these changes
Jul 22, 2026
cariad
left a comment
cariad
left a comment
Contributor
There was a problem hiding this comment.
What I think this PR does
- Upgrade
requestsfrom 2.32.4 to 2.34.2. - Raise the threshold for
certifi,urllib3, andchardet— but doesn't affect what versions we install because we're already within the threshold.
What I did
- Pull the branch and run
poetry install— confirmed onlyrequestswas upgraded, and it was upgraded from 2.32.4 to 2.34.2. - Ran the unit tests:
poetry run pytest tests/unit— confirmed all pass. - Eyeballed the release and intermediate releases of
requeststo check for anything we need to know — all looks good:- https://github.com/psf/requests/releases#release-v2.32.5
- https://github.com/psf/requests/releases#release-v2.33.0
- https://github.com/psf/requests/releases#release-v2.33.1
- https://github.com/psf/requests/releases#release-v2.34.0 — added type hints, good to know!
- https://github.com/psf/requests/releases#release-v2.34.1
- https://github.com/psf/requests/releases#release-v2.34.2
Observations
2.34.0: Requests no longer incorrectly strips duplicate leading slashes in URI paths.
Behaviour we should watch out for, in case we have accidental duplicate leading slashes but didn't notice until now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps requests from 2.32.4 to 2.34.2 via
poetry update requests. Onlypoetry.lockis changed; thepyproject.tomlconstraint is untouched.requestsis important. The 2.33-2.34 diff is bug fixes and typing related changes. Link to notes: https://github.com/psf/requests/blob/main/HISTORY.md