Center 8-bit video modes in the SHR-width frame - #60
Merged
Conversation
KEGS left-aligns the 560-wide 8-bit modes (40/80-column text, GR, HGR, DHGR) with the 640-wide super-hires frame, putting all 80 leftover pixels in the right border and making those modes look shifted left. Center them instead: each 8-bit line is drawn 40 pixels further right and the side borders absorb 40 pixels apiece. The shift is per-line (g_video_a2_x_offset, set by video_refresh_line and applied to the change rectangles by video_update_edges), so screens mixing super-hires and 8-bit lines stay correct, and update_border_line paints the mode-dependent border widths to match. Configurable as "centera2" (Display Effects menu / -centera2 on the command line), default on; 0 restores the KEGS left-aligned look. Toggling applies live via a full reparse, using the same value-changed-since-last-frame pattern as g_status_enable. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012YhTRt358eMKiNLiDXVDAB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KEGS left-aligns the 560-wide 8-bit modes (40/80-column text, GR, HGR, DHGR) with the 640-wide super-hires frame, putting all 80 leftover pixels in the right border and making those modes look shifted left. Center them instead: each 8-bit line is drawn 40 pixels further right and the side borders absorb 40 pixels apiece. The shift is per-line (g_video_a2_x_offset, set by video_refresh_line and applied to the change rectangles by video_update_edges), so screens mixing super-hires and 8-bit lines stay correct, and update_border_line paints the mode-dependent border widths to match.
Configurable as "centera2" (Display Effects menu / -centera2 on the command line), default on; 0 restores the KEGS left-aligned look. Toggling applies live via a full reparse, using the same value-changed-since-last-frame pattern as g_status_enable.
Claude-Session: https://claude.ai/code/session_012YhTRt358eMKiNLiDXVDAB