fix(session): preserve workspace history during local reconnects#1135
Draft
benjaminshafii wants to merge 3 commits intodevfrom
Draft
fix(session): preserve workspace history during local reconnects#1135benjaminshafii wants to merge 3 commits intodevfrom
benjaminshafii wants to merge 3 commits intodevfrom
Conversation
Use the active workspace root instead of stale engine directories when reloading local sessions so workspace creation, switching, and restart flows do not hide another workspace's history. Add a regression check for stale session loads overwriting sidebar and route state.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Expand and canonicalize persisted local workspace paths before deriving workspace IDs or reconnecting. This repairs older Starter entries saved with tilde or non-canonical paths, which could cause restart-time session reloads and new-session creates to scope against the wrong directory.
Use one slash-normalized directory format for local session create, delete, and sidebar client scope so Windows worker switches query the same session directory they were created under. Add a focused regression check for Windows-style transport parity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/session/:idroutesTesting
pnpm install --frozen-lockfilepnpm --filter @openwork/app test:session-scopepnpm --filter @openwork/app test:session-switchpnpm --filter @openwork/app test:e2epnpm --filter @openwork/app test:session-scope25 timespnpm --filter @openwork/app test:session-switch10 timesNotes
pnpm --filter @openwork/app typecheckis currently blocked by pre-existing syntax errors inapps/app/src/i18n/locales/index.tsandapps/app/src/i18n/index.ts.