fix: decode APP0 segments using declared segment length#26
Closed
byrnehollander wants to merge 1 commit into
Closed
fix: decode APP0 segments using declared segment length#26byrnehollander wants to merge 1 commit into
byrnehollander wants to merge 1 commit into
Conversation
APP0 was decoded as a fixed-size JFIF struct, leaving any remaining segment bytes (thumbnails, JFXX payloads, trailing data such as Apple MPF "AMPF") in the stream and desynchronizing the parser on the next marker. Decode the payload as length-framed instead, matching how the EXIF marker is handled, and re-enable ExifTool.jpg in the snapshot suite. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
byrnehollander
force-pushed
the
codex/decode-app0-segments
branch
from
b6c03d7 to
ca0f836
Compare
byrnehollander
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed in favor of #27 - sorry for the noise!