Skip to content

[pre-commit.ci] pre-commit autoupdate#213

Merged
diazona merged 2 commits into
mainfrom
pre-commit-ci-update-config
Jun 27, 2026
Merged

[pre-commit.ci] pre-commit autoupdate#213
diazona merged 2 commits into
mainfrom
pre-commit-ci-update-config

Conversation

@diazona

diazona commented Apr 6, 2026

Copy link
Copy Markdown
Owner

Huh lots of errors on this one... I'm having a busy week so it may be a while until I get to look into it, but I will when I get time if nobody else does first.

@diazona

diazona commented Apr 15, 2026

Copy link
Copy Markdown
Owner

I did some investigation and found the errors are somehow related to setuptools-scm>=10 adding a new dependency vcs-versioning. It looks like vcs-versioning doesn't get installed in the environment used to build the package, even though it should be.

@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from e065ef4 to 7ff72f8 Compare May 4, 2026 20:04
@diazona

diazona commented May 30, 2026

Copy link
Copy Markdown
Owner

I had to take some time away from this because of travel and my computer dying for a while (:cry:), but now that I have a bit of time to investigate again: I think this may be a fundamental problem with how we run our distribution package tests. It looks like when running python setup.py ... or the equivalent (which we do in our tests), setuptools installs only the exact requirements listed in the setup_requires config option, not their dependencies. That was fine as long as setuptools and setuptools-scm vendored all their dependencies, perhaps except for a couple very standard packages (like packaging), but now that a recent version of setuptools-scm has a bona fide third-party dependency (vcs-versioning), we can't get away with it anymore.

I think the fix may require some kind of hacky workaround that checks for setuptools-scm and injects vcs-versioning into the list of build-time required packages. Either that or we use the PEP 517/518 build machinery to set up an environment in which to run (the equivalent of) python setup.py pyproject, but part of the point of this tool is to support packages that may not be using a recent enough version of setuptools to support modern build backends, so I think I'd rather avoid relying on modern tech.

Either way, it's nothing to do with this particular PR, it needs to be fixed on main. I'll continue to work on this as I have time.

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.15.4 → v0.15.15](astral-sh/ruff-pre-commit@v0.15.4...v0.15.15)
- [github.com/pre-commit/mirrors-mypy: v1.19.1 → v2.1.0](pre-commit/mirrors-mypy@v1.19.1...v2.1.0)
- [github.com/psf/black-pre-commit-mirror: 26.1.0 → 26.5.1](psf/black-pre-commit-mirror@26.1.0...26.5.1)
- [github.com/rhysd/actionlint: v1.7.11 → v1.7.12](rhysd/actionlint@v1.7.11...v1.7.12)
- [github.com/igorshubovych/markdownlint-cli: v0.47.0 → v0.48.0](igorshubovych/markdownlint-cli@v0.47.0...v0.48.0)
@diazona

diazona commented Jun 26, 2026

Copy link
Copy Markdown
Owner

#219 has a workaround 🤞

This brings in the fix for the missing vcs-versioning module error.
@diazona diazona merged commit 5f6e903 into main Jun 27, 2026
14 checks passed
@diazona diazona deleted the pre-commit-ci-update-config branch June 27, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant