Fix: Deployments Needing Attention panel#4
Open
0hlov3 wants to merge 1 commit into
Open
Conversation
This fixes a Problem when multiple deployments or replicasets have the same name in the Kubernetes Cluster but are in different namespaces. Changelog: fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the Deployments Needing Attention panel rendered no results if the cluster contained deployments with the same name in different namespaces and/or multiple ReplicaSets for those deployments.
Problem
Deployment names are not globally unique in Kubernetes. Several of the PromQL expressions in the panel grouped or matched only by deployment, which leads to label collisions (or invalid many-to-many matches) when the same deployment name appears across multiple namespaces. In practice, this caused the panel to show nothing for those environments.
What I changed
Why this helps
verified the fix in my cluster where:
Note: I can’t guarantee the dashboard behaves exactly as originally intended across all setups and data sources, but in my environment the results look correct and significantly more reliable. Feedback and further adjustments welcome.