fix: avoid misleading failure when metadata delete times out (DHIS2-15823) - #986
Draft
karolinelien wants to merge 5 commits into
Draft
fix: avoid misleading failure when metadata delete times out (DHIS2-15823)#986karolinelien wants to merge 5 commits into
karolinelien wants to merge 5 commits into
Conversation
…5823)
A long-running delete (eg. a Category Combo whose category option combos
take a while to cascade-delete) can exceed a proxy/connection timeout. The
client request is aborted or gets a gateway timeout while the backend keeps
processing and completes the delete, but the UI showed a hard "Failed to
delete" error - misleading the user into thinking nothing happened.
- Add isMaybeStillProcessingError() to detect network/aborted errors and
408/502/503/504 gateway responses where the operation may still complete
server-side.
- Show a softer "The deletion may still be in progress" warning in that case,
prompting the user to refresh before retrying.
- Fix the {{messages}} placeholder in the failure message, which was never
interpolated and always rendered empty; now shows the backend message.
AI Assisted
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Detect gateway timeouts (408/502/503/504) even when the proxy returns a
non-JSON body: app-runtime only populates details.httpStatusCode for DHIS2
JSON responses, so fall back to parsing the status from the error message
("...statusText (504)"). Previously the 502/503/504 branch never fired
against a real reverse-proxy timeout - the headline case for this fix.
- Drop redundant type cast and optional chaining on the non-optional
FetchError.details field (extract getHttpStatusCode helper).
- Mark the status-code lookup table readonly; drop redundant cast in the test.
- Consolidate the two near-identical NoticeBox blocks into one to remove
duplicated JSX.
- Add tests for proxy timeouts (status only in message) and for an unknown
error with no status code.
AI Assisted
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author
|
Ran two independent reviews (correctness + SonarQube-style quality) and pushed fixes. Material correctness fix (found in review): the original 502/503/504 detection relied on Quality fixes:
AI Assisted |
Convert MAYBE_STILL_PROCESSING_STATUS_CODES to a ReadonlySet and use .has() instead of Array.includes(), resolving the SonarCloud code smell that failed the quality gate. AI Assisted Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Reword the timeout warning to "The request timed out. The operation may
still be processing in the background, refresh to confirm."
- Add DeleteAction.spec.tsx covering the timeout ("still processing") branch
and the hard-failure branch (backend error messages shown), giving the new
delete-error handling test coverage.
AI Assisted
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change the title to 'The operation may still be in progress'. AI Assisted Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
karolinelien
force-pushed
the
fix/misleading-delete-timeout-error
branch
from
July 6, 2026 13:06
edcb1ec to
fbd56fd
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes DHIS2-15823.
A long-running metadata delete — e.g. a Category Combo whose category option combos take a while to cascade-delete — can exceed a proxy/connection timeout. The client request is aborted or receives a gateway timeout while the backend keeps processing and completes the delete, but the UI showed a hard "Failed to delete" error, misleading the user into thinking nothing happened (and prompting duplicate delete attempts).
The original ticket described this in the legacy maintenance app ("undefined was not deleted"). That app is gone, but the same behaviour is still present in this app in a different form — this PR addresses it here.
Changes
isMaybeStillProcessingError()to detectnetwork/abortedfetch errors and408/502/503/504gateway responses, where the operation may still be completing server-side.{{messages}}placeholder in the failure message, which was never interpolated and always rendered empty; it now shows the backend message.Notes / limitations
Testing
yarn check-types✅yarn d2-style check(eslint + prettier + tsc) ✅src/lib/errors/errors.spec.ts(13 cases) ✅categoryCombos/List.spec.tsxsmoke test ✅AI Assisted
@