fix: dashboard map fixes - #3779
Merged
Merged
Conversation
|
Contributor
|
🚀 Deployed on https://pr-3779.maps.netlify.dhis2.org |
HendrikThePendric
approved these changes
Sep 30, 2026
Contributor
|
🎉 This PR is included in version 101.17.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-22188 and 2 other unreported bugs
Description
On 2.43+, Earth Engine layers on dashboard map items fail with "Unknown format".
1. Load each layer config once (
LayerLoader)On 2.43+, period types arrive after the first render, which re-runs the loader effect. Loaders change their config in place (the Earth Engine loader deletes
config.config), so the second run produced a layer withoutformat.LayerLoadernow loads a given config object only once.2. Keep pending layer loaders mounted (plugin
Map)Layers marked
isLoadinghad their loader unmounted on any re-render (resize, new props). Thematic and event loaders waiting for period types then never loaded, and the item stayed on the spinner. Loaders now stay mounted until loaded. The marking guarded against re-running loads (13ffd7a), which fix 1 now covers. This depends on fix 1.3. Keep legend content within its box on small items
Since c2b725d, legend content could overflow its box on short items. It now shrinks to fit and scrolls.
Quality checklist
Add N/A to items that are not applicable.