fix: add various new scripts to glyphs [DHIS2-21946] - #3766
Draft
BRaimbault wants to merge 2 commits into
Draft
BRaimbault wants to merge 2 commits into
BRaimbault wants to merge 2 commits into
Conversation
Contributor
|
🚀 Deployed on https://pr-3766.maps.netlify.dhis2.org |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Implements DHIS2-21946
Description
Open Sans does not support Arabic, Bengali, Devanagari, Ethiopic, Khmer, Myanmar, Oriya, Sinhala or Thai scripts. Lao support was added previously: #3364
Quality checklist
Add N/A to items that are not applicable.
Known issues
MapLibre v6.9 adds native shaping fixes, but only Khmer, Myanmar, and Devanagari are explicitly confirmed in the changelog. Bengali, Oriya, Sinhala, Lao, and Thai are not mentioned. A v6 upgrade may not resolve these and would need direct testing to confirm. The upgrade itself is non-trivial: MapLibre v6 is ESM-only (dropped CommonJS/UMD), which breaks @dhis2/maps-gl's own CJS build output and its Jest test setup.
Screenshots