Skip to content

fix: add various new scripts to glyphs [DHIS2-21946] - #3766

Draft
BRaimbault wants to merge 2 commits into
masterfrom
fix/DHIS2-21946
Draft

BRaimbault wants to merge 2 commits into
masterfrom
fix/DHIS2-21946

Conversation

@BRaimbault

@BRaimbault BRaimbault commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Implements DHIS2-21946

Description

Open Sans does not support Arabic, Bengali, Devanagari, Ethiopic, Khmer, Myanmar, Oriya, Sinhala or Thai scripts. Lao support was added previously: #3364


Quality checklist

Add N/A to items that are not applicable.


Known issues

  • Khmer, Myanmar, Devanagari, Oriya, Sinhala, Bengali, Lao, Thai all show some degree of incorrect rendering for words with conjuncts, stacked marks, or vowel/tone-mark positioning (severity ranges from a visible virama mark instead of a ligature, to fully broken/disconnected conjuncts). Cause: MapLibre 5.x does not perform contextual text shaping.
    MapLibre v6.9 adds native shaping fixes, but only Khmer, Myanmar, and Devanagari are explicitly confirmed in the changelog. Bengali, Oriya, Sinhala, Lao, and Thai are not mentioned. A v6 upgrade may not resolve these and would need direct testing to confirm. The upgrade itself is non-trivial: MapLibre v6 is ESM-only (dropped CommonJS/UMD), which breaks @dhis2/maps-gl's own CJS build output and its Jest test setup.
  • Arabic: fixed separately via setRTLTextPlugin in @dhis2/maps-gl. Note: if/when the MapLibre v6.9 upgrade above happens, this plugin becomes unnecessary and should be removed.

Screenshots

image

@dhis2-bot

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://pr-3766.maps.netlify.dhis2.org

@dhis2-bot
dhis2-bot temporarily deployed to netlify September 9, 2026 16:19 Inactive
@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2026

Copy link
Copy Markdown

@dhis2-bot
dhis2-bot temporarily deployed to netlify September 9, 2026 17:39 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants