feat: extend data table support to TE, thematic, and event layers [PR5] - #3726
Open
BRaimbault wants to merge 47 commits into
Open
BRaimbault wants to merge 47 commits into
BRaimbault wants to merge 47 commits into
Conversation
Contributor
|
🚀 Deployed on https://pr-3726.maps.netlify.dhis2.org |
BRaimbault
changed the title
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
… set Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
isExtended was set unconditionally before the server-cluster decision, so a layer that became server-clustered while its data table was open got isExtended:true stamped even though no client dataset was ever loaded. That silently blocked the reload useLayersLoader triggers when forceClientCluster is set, so clicking "Show event details" appeared to do nothing instead of loading the table. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…total, once rendering client-side Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Same drift as prior rebases: the merge driver's timestamp-only resolutions left message entries stale relative to the merged source. Re-run the extraction to bring it back in sync.
isCollapsed was the only local-state input to getPanelHeights, with everything else (window height, dataTableHeight, CSS vars) pulled straight from context - move that plumbing into its own hook per review feedback.
The itemContent render prop had grown into a large inline function mixing checkbox-cell and per-column cell rendering (color/icon/date renderers, pinning). Extract it into its own component, wrapped in a memoized callback, matching the existing fixedHeaderContent pattern.
BRaimbault
force-pushed
the
feat/datatable-pr5-more-layer-types
branch
from
September 10, 2026 12:49
d839b01 to
078d271
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of DHIS2-21456
Description
Extends the data table to the remaining layer types and rendering modes from the epic:
Also included, surfaced while wiring up event layers:
spatialSupport), with aforceClientClusterescape hatchvalueTypecoercion for TE columns, a race when editing filters/columns while a server-clustered event layer's data is still extending, a resize-cancel bug, a crash + dead code path inparseLayerConfig, header alignment, and a data table performance passQuality checklist
Known issues
<input type="color">; deferred to a follow-up