Conversation
This replaces the old visualization prop which is an object.
Contributor
|
🚀 Deployed on https://pr-387.event-visualizer.netlify.dhis2.org |
edoardo
changed the title
|
HendrikThePendric
previously approved these changes
Sep 21, 2026
HendrikThePendric
dismissed
their stale review
September 21, 2026 13:11
I need to review in more detail
HendrikThePendric
approved these changes
Sep 21, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of DHIS2-21962
Description
The
event-visualizerappKey is already used, so we need a different key for the EVER app.individual-data-visualizeris the current most likely candidate.The app's title is also updated accordingly.
The dashboard app is handling "standalone" plugins differently then the others.
The "standalone" plugins fetch the visualization directly and don't need it to be passed via props from dashboard app.
This means we need to read the visualization id from the
visualizationIdprop, instead of thevisualizationone which carried the whole vis object.Quality checklist
Add N/A to items that are not applicable and check them.